Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use packaging instead of pkg_resources #412

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Use packaging instead of pkg_resources #412

merged 1 commit into from
Aug 5, 2024

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jul 31, 2024

Purpose

As explained here the parse_version method we use in pySNOPT is deprecated. Here I switched to the packaging package which is the recommended approach, see e.g. here.

Expected time until merged

1 day.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner July 31, 2024 17:50
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.92%. Comparing base (7e862db) to head (ee4b6aa).

Files Patch % Lines
pyoptsparse/pySNOPT/pySNOPT.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files          22       22           
  Lines        3334     3334           
=======================================
  Hits         2498     2498           
  Misses        836      836

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marcomangano
marcomangano approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@ewu63
Copy link
Collaborator Author

ewu63 commented Aug 5, 2024

bump @lamkina

@lamkina lamkina merged commit bc021e4 into main Aug 5, 2024
12 of 13 checks passed
@lamkina lamkina deleted the maint/use-packaging branch August 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamkina lamkina lamkina approved these changes

@marcomangano marcomangano marcomangano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewu63 @lamkina @marcomangano